LayoutTests/editing/execCommand/delete-hidden-crash.html - Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/delete-hidden-crash.html

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7

	8 onload = function(){
	Yuta Kitamura 2014/06/18 08:08:11 Space required before the brace. Space required before the brace. yosin_UTC9 2014/06/19 07:36:56 Done. Show quoted text On 2014/06/18 08:08:11, Yuta Kitamura wrote: > Space required before the brace. Done.
	9 document.execCommand('SelectAll')
	Yuta Kitamura 2014/06/18 08:08:11 Bad indentation. Bad indentation. yosin_UTC9 2014/06/19 07:36:57 Done. Show quoted text On 2014/06/18 08:08:11, Yuta Kitamura wrote: > Bad indentation. Done.
	10 span = document.getElementsByTagName('span')[0];

	11 span.contentEditable = 'true';

	12 span.textContent = 'bar';

	13 document.execCommand('InsertText', false, '1');

	14 document.body.textContent = 'PASS if Blink doesn\'t crash.';

	15 };

	16 </script>

	17 <style>

	18 * { visibility:visible; }

	19 .inline { display:inline; }

	20 *:only-child { visibility:hidden; }

	21 </style>

	22 </head>

	23 <body>

	24 <table>

	25 <tbody>
	Yuta Kitamura 2014/06/18 08:08:11 Indentation is not necessary here. If you need th Indentation is not necessary here. If you need the indentation here, please use 4-space indent. yosin_UTC9 2014/06/19 07:36:56 Done. Show quoted text On 2014/06/18 08:08:11, Yuta Kitamura wrote: > Indentation is not necessary here. > > If you need the indentation here, please use > 4-space indent. Done.
	26 <tr>

	27 <td>

	28 <span>

	29 <table></table><span></span>

	30 </span>

	31 </td>

	32 </tr>

	33 <tr>

	34 <td>

	35 <td class="inline">

	36 foo

	37 </tr>

	38 </tbody>
	Yuta Kitamura 2014/06/18 08:08:11 This test case is very hard to understand... It w This test case is very hard to understand... It would be awesome if you can come up with a simpler test case. At least the second <tr> does not seem relevant to this test. yosin_UTC9 2014/06/19 07:36:56 Done. Show quoted text On 2014/06/18 08:08:11, Yuta Kitamura wrote: > This test case is very hard to understand... > > It would be awesome if you can come up with a simpler > test case. > > At least the second <tr> does not seem relevant to > this test. Done.
	39 </body>
	Yuta Kitamura 2014/06/18 08:08:11 No close tag of <table>? No close tag of <table>? yosin_UTC9 2014/06/19 07:36:56 Done. Show quoted text On 2014/06/18 08:08:11, Yuta Kitamura wrote: > No close tag of <table>? Done.
	40 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/delete-hidden-crash-expected.txt » ('j') | Source/core/editing/htmlediting.h » ('J')