Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340403003: SaveFlags be-gone (Closed)

Created:
6 years, 6 months ago by f(malita)
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Visibility:
Public.

Description

SaveFlags be-gone Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/5f6102d

Patch Set 1 #

Total comments: 1

Patch Set 2 : SKP version bump. #

Total comments: 2

Patch Set 3 : Removed canvasstate GM #

Total comments: 3

Patch Set 4 : Attempting to fix the base URL #

Patch Set 5 : One more baseurl attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -376 lines) Patch
M gm/canvasstate.cpp View 1 2 1 chunk +0 lines, -180 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 1 2 3 5 chunks +4 lines, -23 lines 0 comments Download
M include/core/SkPicture.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkProxyCanvas.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 6 chunks +13 lines, -33 lines 0 comments Download
M src/core/SkMatrixClipStateMgr.h View 4 chunks +7 lines, -15 lines 0 comments Download
M src/core/SkMatrixClipStateMgr.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 3 chunks +7 lines, -17 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordOpts.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkRecords.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/CanvasTest.cpp View 1 2 3 1 chunk +1 line, -35 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
f(malita)
I just realized this breaks the serialization format, will revisit. https://codereview.chromium.org/340403003/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/340403003/diff/1/include/core/SkCanvas.h#newcode296 ...
6 years, 6 months ago (2014-06-19 17:24:48 UTC) #1
mtklein
very lgtm https://codereview.chromium.org/340403003/diff/20001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/340403003/diff/20001/expectations/gm/ignored-tests.txt#newcode54 expectations/gm/ignored-tests.txt:54: canvas-state I think we can just delete ...
6 years, 6 months ago (2014-06-19 19:09:34 UTC) #2
f(malita)
https://codereview.chromium.org/340403003/diff/20001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/340403003/diff/20001/expectations/gm/ignored-tests.txt#newcode54 expectations/gm/ignored-tests.txt:54: canvas-state On 2014/06/19 19:09:34, mtklein wrote: > I think ...
6 years, 6 months ago (2014-06-19 19:47:06 UTC) #3
robertphillips
hooray - lgtm https://codereview.chromium.org/340403003/diff/40001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/340403003/diff/40001/src/core/SkCanvas.cpp#newcode206 src/core/SkCanvas.cpp:206: if (NULL != prev) { Can ...
6 years, 6 months ago (2014-06-23 14:33:40 UTC) #4
f(malita)
https://codereview.chromium.org/340403003/diff/40001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/340403003/diff/40001/src/core/SkCanvas.cpp#newcode206 src/core/SkCanvas.cpp:206: if (NULL != prev) { On 2014/06/23 14:33:39, robertphillips ...
6 years, 6 months ago (2014-06-23 14:39:12 UTC) #5
reed1
lgtm
6 years, 5 months ago (2014-06-30 12:47:13 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 5 months ago (2014-06-30 12:47:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 12:50:00 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 5 months ago (2014-06-30 12:50:01 UTC) #9
f(malita)
Committed patchset #5 manually as r5f6102d (presubmit successful).
6 years, 5 months ago (2014-06-30 14:13:52 UTC) #10
scroggo
6 years, 5 months ago (2014-07-01 17:21:57 UTC) #11
Message was sent while issue was closed. 
On 2014/06/30 14:13:52, Florin Malita wrote:
> Committed patchset #5 manually as r5f6102d (presubmit successful).

This breaks Android's master-skia build. See
http://android-build/builds/git_master-skia-linux-aosp_x86-userdebug/1258346/...

Powered by Google App Engine
This is Rietveld 408576698