Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 33983003: Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, feature-media-reviews_chromium.org, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it As a step to let toFoo use DEFINE_TYPE_CASTS, this cl introduce DEFINE_RENDER_OBJECT_TYPE_CASTS, which can support more helper functions rather than manual toFoo(). This cl will help to detect bad type casts further. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -797 lines) Patch
M Source/core/rendering/RenderBR.h View 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +1 line, -27 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderButton.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderCombineText.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderCounter.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderDetailsMarker.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderFieldset.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderFrame.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.h View 1 chunk +1 line, -9 lines 0 comments Download
M Source/core/rendering/RenderFullScreen.h View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderHTMLCanvas.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderIFrame.h View 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/rendering/RenderImage.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderListBox.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderListItem.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderMarquee.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderMedia.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderMenuList.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderMeter.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnBlock.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderPart.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderProgress.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderQuote.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderRegion.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderRubyRun.h View 1 chunk +1 line, -13 lines 0 comments Download
M Source/core/rendering/RenderScrollbarPart.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderSearchField.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderSlider.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTableCaption.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTableCol.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTextControl.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderTextControlMultiLine.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/RenderWidget.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGPath.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.h View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGViewportContainer.h View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-22 03:40:34 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-22 03:47:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/33983003/1
7 years, 2 months ago (2013-10-22 03:47:55 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 09:34:25 UTC) #4
Message was sent while issue was closed. 
Change committed as 160170

Powered by Google App Engine
This is Rietveld 408576698