Source/core/rendering/RenderFrame.h - Issue 33983003: Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFrame.h

Issue 33983003: Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFrame.h

diff --git a/Source/core/rendering/RenderFrame.h b/Source/core/rendering/RenderFrame.h

index 848b9257b8257f0f33e3b54696d683b49a47642a..55391b98bd9da95eae4812de09b0162d05b4159a 100644

--- a/Source/core/rendering/RenderFrame.h

+++ b/Source/core/rendering/RenderFrame.h

@@ -45,14 +45,7 @@ private:

virtual void viewCleared();

};

-inline RenderFrame* toRenderFrame(RenderObject* object)

- ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isFrame());

- return static_cast<RenderFrame*>(object);

-// This will catch anyone doing an unnecessary cast.

-void toRenderFrame(const RenderFrame*);

+DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFrame, isFrame());

} // namespace WebCore

« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderFrameSet.h » ('j') | no next file with comments »