Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/video_decoder.h

Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/audio_decoder.h ('K') | « media/base/audio_decoder.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | media/filters/audio_renderer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index 5111f53e9fbceef9f81d0a83b8575e3b4f9e8614..55594b4ad39d7a2e421a8afbb5b2a9fd41224f74 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -29,7 +29,9 @@ class MEDIA_EXPORT VideoDecoder {
kDecryptError // Decrypting error happened.
};
- // Callback to return decode frames.
+ // Callback for VideoDecoder to return a decoded frame whenever it becomes
+ // available. Only valid frames should be returned via this callback. EOS
+ // frames should not be returned via this callback.
Sergey Ulanov 2014/06/16 23:49:32 same here as in audio_decoder.h
xhwang 2014/06/17 18:56:35 Done.
typedef base::Callback<void(const scoped_refptr<VideoFrame>&)> OutputCB;
// Callback type for Decode(). Called after the decoder has completed decoding
« media/base/audio_decoder.h ('K') | « media/base/audio_decoder.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | media/filters/audio_renderer_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698