Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: media/base/audio_decoder.h

Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_decoder.h » ('j') | media/base/video_decoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_decoder.h
diff --git a/media/base/audio_decoder.h b/media/base/audio_decoder.h
index 285d91b952ef6dd6828bc4944aaba345999ee889..05c6ae34cd037357146f5e2a2a90ec0c040da3a0 100644
--- a/media/base/audio_decoder.h
+++ b/media/base/audio_decoder.h
@@ -30,7 +30,9 @@ class MEDIA_EXPORT AudioDecoder {
kDecryptError // Decrypting error happened.
};
- // Callback to return decoded buffers.
+ // Callback for AudioDecoder to return a decoded frame whenever it becomes
+ // available. Only valid frames should be returned via this callback. EOS
+ // frames should not be returned via this callback.
Sergey Ulanov 2014/06/16 23:49:32 nit: the last two sentences can be reduced to one.
xhwang 2014/06/17 18:56:35 Done.
typedef base::Callback<void(const scoped_refptr<AudioBuffer>&)> OutputCB;
// Callback for Decode(). Called after the decoder has completed decoding
« no previous file with comments | « no previous file | media/base/video_decoder.h » ('j') | media/base/video_decoder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698