Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: media/filters/audio_renderer_impl_unittest.cc

Issue 339653003: No EOS frame in {Audio|Video}Decoder::OutputCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl_unittest.cc
diff --git a/media/filters/audio_renderer_impl_unittest.cc b/media/filters/audio_renderer_impl_unittest.cc
index b815176683067ae3b4f516c42416167882ef3141..55a7cde63df93377ac0c811d120e35b70d568d03 100644
--- a/media/filters/audio_renderer_impl_unittest.cc
+++ b/media/filters/audio_renderer_impl_unittest.cc
@@ -290,8 +290,10 @@ class AudioRendererImplTest : public ::testing::Test {
}
void DeliverEndOfStream() {
+ LOG(ERROR) << __FUNCTION__;
Sergey Ulanov 2014/06/16 23:49:32 remove?
xhwang 2014/06/17 18:56:35 Updated this function and removed the logs.
// Repeatedly return EOS buffer
while (!decode_cb_.is_null()) {
+ LOG(ERROR) << __FUNCTION__ << "111";
DeliverBuffer(AudioDecoder::kOk, AudioBuffer::CreateEOSBuffer());
}
}
@@ -480,7 +482,7 @@ class AudioRendererImplTest : public ::testing::Test {
void DeliverBuffer(AudioDecoder::Status status,
const scoped_refptr<AudioBuffer>& buffer) {
CHECK(!decode_cb_.is_null());
- if (buffer)
+ if (buffer && !buffer->end_of_stream())
output_cb_.Run(buffer);
base::ResetAndReturn(&decode_cb_).Run(status);

Powered by Google App Engine
This is Rietveld 408576698