Add a compile time error for non-static const fields

Add a compile time error for non-static const fields

BUG=11049
Committed through https://codereview.chromium.org/443923002/

[srawlins, 2014-06-20 20:56:22]

None of the MODIFIER warnings have tests, so I didn't add one :( Let me know
where this test should exist, and I can add some.

$ git grep _MODIFIERS tests
$

[Johnni Winther, 2014-06-23 07:38:48]

On 2014/06/20 20:56:22, srawlins wrote:
> None of the MODIFIER warnings have tests, so I didn't add one :( Let me know
> where this test should exist, and I can add some.
> 
> $ git grep _MODIFIERS tests
> $

You can put an example directly on the MessageKind. Look for instance at
UNIMPLEMENTED_METHOD_ONE. We have a unittest that checks that the examples
result in the corresponding messages.

[srawlins, 2014-06-24 21:43:37]

On 2014/06/23 07:38:48, Johnni Winther wrote:
> On 2014/06/20 20:56:22, srawlins wrote:
> > None of the MODIFIER warnings have tests, so I didn't add one :( Let me know
> > where this test should exist, and I can add some.
> > 
> > $ git grep _MODIFIERS tests
> > $
> 
> You can put an example directly on the MessageKind. Look for instance at
> UNIMPLEMENTED_METHOD_ONE. We have a unittest that checks that the examples
> result in the corresponding messages.

Thanks Johnni, added a test.

[Johnni Winther, 2014-06-25 07:21:03]

LGTM

Thanks for the fix.

https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:996: howToFix: "Add a
static modifier, or remove the const modifier.",
'Add a ... or remove the ...' -> 'Try adding a ... or removing the ...'.

We try to be polite in the [howToFix] since might misunderstand the underlying
reason for the error and a wrong command-like [howToFix] seems rude or arrogant
or simply just stupid.

[Johnni Winther, 2014-06-30 12:41:39]

On 2014/06/25 07:21:03, Johnni Winther wrote:
> LGTM
> 
> Thanks for the fix.
> 
>
https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
> File sdk/lib/_internal/compiler/implementation/warnings.dart (right):
> 
>
https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
> sdk/lib/_internal/compiler/implementation/warnings.dart:996: howToFix: "Add a
> static modifier, or remove the const modifier.",
> 'Add a ... or remove the ...' -> 'Try adding a ... or removing the ...'.
> 
> We try to be polite in the [howToFix] since might misunderstand the underlying
> reason for the error and a wrong command-like [howToFix] seems rude or
arrogant
> or simply just stupid.

Should I commit this CL for you?

[srawlins, 2014-07-11 17:52:13]

The CQ bit was checked by srawlins@google.com

[commit-bot: I haz the power, 2014-07-11 17:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 17:56:01]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[srawlins, 2014-07-15 20:13:28]

https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/339583004/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:996: howToFix: "Add a
static modifier, or remove the const modifier.",
On 2014/06/25 07:21:03, Johnni Winther wrote:
> 'Add a ... or remove the ...' -> 'Try adding a ... or removing the ...'.
> 
> We try to be polite in the [howToFix] since might misunderstand the underlying
> reason for the error and a wrong command-like [howToFix] seems rude or
arrogant
> or simply just stupid.

Done.

[srawlins, 2014-07-15 20:13:32]

The CQ bit was checked by srawlins@google.com

[commit-bot: I haz the power, 2014-07-15 20:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 20:13:50]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.