Add a compile time error for non-static const fields

sdk/lib/_internal/compiler/implementation/warnings.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 const DONT_KNOW_HOW_TO_FIX = "";
 
 /**
  * The messages in this file should meet the following guide lines:
@@ skipping 973 matching lines @@
   C() {
     return 1;
   }
 }
 
 main() => new C();"""]);
 
   static const MessageKind ILLEGAL_FINAL_METHOD_MODIFIER = const MessageKind(
       "Cannot have final modifier on method.");
 
+  static const MessageKind ILLEGAL_CONST_FIELD_MODIFIER = const MessageKind(
+      "Cannot have const modifier on non-static field.",
+      howToFix: "Add a static modifier, or remove the const modifier.",

[Johnni Winther, 2014/06/25 07:21:03]

'Add a ... or remove the ...' -> 'Try adding a ... or removing the ...'.

We try to be polite in the [howToFix] since might misunderstand the underlying
reason for the error and a wrong command-like [howToFix] seems rude or arrogant
or simply just stupid.

[srawlins, 2014/07/15 20:13:28]

Done.

+      examples: const ["""
+class C {
+  const int a = 1;
+}
+
+main() => new C();"""]);
+
   static const MessageKind ILLEGAL_CONSTRUCTOR_MODIFIERS = const MessageKind(
       "Illegal constructor modifiers: '#{modifiers}'.");
 
   static const MessageKind ILLEGAL_MIXIN_APPLICATION_MODIFIERS =
       const MessageKind(
           "Illegal mixin application modifiers: '#{modifiers}'.");
 
   static const MessageKind ILLEGAL_MIXIN_SUPERCLASS = const MessageKind(
       "Class used as mixin must have Object as superclass.");
 
@@ skipping 1077 matching lines @@
   static String convertToString(value) {
     if (value is ErrorToken) {
       // Shouldn't happen.
       return value.assertionMessage;
     } else if (value is Token) {
       value = value.value;
     }
     return '$value';
   }
 }