Issue 339503007: Descriptive log for HID device open failure on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339503007: Descriptive log for HID device open failure on Linux. (Closed)

Created:
6 years, 6 months ago by Reilly Grant (use Gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Descriptive log for HID device open failure on Linux. Log a human readable message describing the reason why Chromium failed to open a HID device node on Linux instead of the base::File error code. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278684

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	device/hid/hid_connection_linux.cc	View		1 chunk	+9 lines, -8 lines	0 comments	Download
	M	device/hid/hid_service_linux.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Reilly Grant (use Gerrit)

The CQ bit was checked by reillyg@chromium.org

6 years, 6 months ago (2014-06-19 23:12:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/339503007/1

6 years, 6 months ago (2014-06-19 23:15:05 UTC) #4

Message was sent while issue was closed.

Change committed as 278684

Expand Messages | Collapse Messages