Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: device/hid/hid_service_linux.cc

Issue 339503007: Descriptive log for HID device open failure on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/hid/hid_connection_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_service_linux.cc
diff --git a/device/hid/hid_service_linux.cc b/device/hid/hid_service_linux.cc
index 5f9f0dcff76f67ad43097382d466e21d4e14ab84..5257dcd874a5a4e64774c8ea0ecfab2f7bda2340 100644
--- a/device/hid/hid_service_linux.cc
+++ b/device/hid/hid_service_linux.cc
@@ -114,7 +114,7 @@ void HidServiceLinux::OnDeviceAdded(udev_device* device) {
std::string dev_node;
if (!FindHidrawDevNode(device, &dev_node)) {
- LOG(ERROR) << "Cannot open HID device as hidraw device.";
+ LOG(ERROR) << "Cannot find device node for HID device.";
return;
}
@@ -122,7 +122,8 @@ void HidServiceLinux::OnDeviceAdded(udev_device* device) {
base::File device_file(base::FilePath(dev_node), flags);
if (!device_file.IsValid()) {
- LOG(ERROR) << device_file.error_details();
+ LOG(ERROR) << "Cannot open '" << dev_node << "': "
+ << base::File::ErrorToString(device_file.error_details());
return;
}
« no previous file with comments | « device/hid/hid_connection_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698