Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2453)

Unified Diff: device/hid/hid_connection_linux.cc

Issue 339503007: Descriptive log for HID device open failure on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/hid/hid_service_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_connection_linux.cc
diff --git a/device/hid/hid_connection_linux.cc b/device/hid/hid_connection_linux.cc
index b6f90a90f9f2b646907a6c0fd9d97f9ce2ea4e80..425d88fa35cd83ac0c29ddeb39b62f59727c314a 100644
--- a/device/hid/hid_connection_linux.cc
+++ b/device/hid/hid_connection_linux.cc
@@ -57,18 +57,19 @@ HidConnectionLinux::HidConnectionLinux(HidDeviceInfo device_info,
base::File::Error file_error = device_file.error_details();
if (file_error == base::File::FILE_ERROR_ACCESS_DENIED) {
+ VLOG(1) << "Access denied opening device read-write, trying read-only.";
+
flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
- base::File device_file(base::FilePath(dev_node), flags);
- if (!device_file.IsValid()) {
- LOG(ERROR) << device_file.error_details();
- return;
- }
- } else {
- LOG(ERROR) << file_error;
- return;
+ device_file = base::File(base::FilePath(dev_node), flags);
}
}
+ if (!device_file.IsValid()) {
+ LOG(ERROR) << "Failed to open '" << dev_node << "': "
+ << base::File::ErrorToString(device_file.error_details());
+ return;
+ }
+
if (fcntl(device_file.GetPlatformFile(), F_SETFL,
fcntl(device_file.GetPlatformFile(), F_GETFL) | O_NONBLOCK)) {
PLOG(ERROR) << "Failed to set non-blocking flag to device file.";
« no previous file with comments | « no previous file | device/hid/hid_service_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698