Update error-handling logic in ChromiumPacketSocketFactory.

Update error-handling logic in ChromiumPacketSocketFactory.

PepperPacketSocketFactory has been updated to handle transient errors
properly in https://codereview.chromium.org/336113002/. This is
correpsonding change for ChromiumPacketSocketFactory. Particularly
ChromiumPacketSocketFactory now tries resending each packet after
EHOSTUNREACH.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278007

[Wez, 2014-06-17 03:27:54]

https://codereview.chromium.org/339503006/diff/20001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_packet_socket_factory.cc (right):

https://codereview.chromium.org/339503006/diff/20001/remoting/client/plugin/p...
remoting/client/plugin/pepper_packet_socket_factory.cc:39: //
remoting/jingle_glue/chromium_socket_factory.cc .
Could we convert the PPAPI error code to a net error code here and then call the
version from jingle_glue here?

https://codereview.chromium.org/339503006/diff/20001/remoting/jingle_glue/chr...
File remoting/jingle_glue/chromium_socket_factory_unittest.cc (right):

https://codereview.chromium.org/339503006/diff/20001/remoting/jingle_glue/chr...
remoting/jingle_glue/chromium_socket_factory_unittest.cc:103: // IPv4 address.
This send is expected to fail internally.
Fail internally? You mean fail without reporting an error?

[Sergey Ulanov, 2014-06-17 22:32:06]

https://codereview.chromium.org/339503006/diff/20001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_packet_socket_factory.cc (right):

https://codereview.chromium.org/339503006/diff/20001/remoting/client/plugin/p...
remoting/client/plugin/pepper_packet_socket_factory.cc:39: //
remoting/jingle_glue/chromium_socket_factory.cc .
On 2014/06/17 03:27:54, Wez wrote:
> Could we convert the PPAPI error code to a net error code here and then call
the
> version from jingle_glue here?

Done.

https://codereview.chromium.org/339503006/diff/20001/remoting/jingle_glue/chr...
File remoting/jingle_glue/chromium_socket_factory_unittest.cc (right):

https://codereview.chromium.org/339503006/diff/20001/remoting/jingle_glue/chr...
remoting/jingle_glue/chromium_socket_factory_unittest.cc:103: // IPv4 address.
This send is expected to fail internally.
On 2014/06/17 03:27:54, Wez wrote:
> Fail internally? You mean fail without reporting an error?

Done.

[Wez, 2014-06-17 22:39:21]

lgtm

https://codereview.chromium.org/339503006/diff/60001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_packet_socket_factory.cc (right):

https://codereview.chromium.org/339503006/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_packet_socket_factory.cc:31: int
PepperErrorToNetError(int error) {
nit: Could this go into e.g. pepper_util.h?

[Sergey Ulanov, 2014-06-17 22:45:02]

https://codereview.chromium.org/339503006/diff/60001/remoting/client/plugin/p...
File remoting/client/plugin/pepper_packet_socket_factory.cc (right):

https://codereview.chromium.org/339503006/diff/60001/remoting/client/plugin/p...
remoting/client/plugin/pepper_packet_socket_factory.cc:31: int
PepperErrorToNetError(int error) {
On 2014/06/17 22:39:21, Wez wrote:
> nit: Could this go into e.g. pepper_util.h?

I don't think it's necessary because it's specific to this file right now, and
it won't be useful for most pepper APIs anyway. We can always move it later,
when it becomes necessary to share it.

[Sergey Ulanov, 2014-06-17 22:51:56]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-06-17 22:54:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyu@chromium.org/339503006/80001

[commit-bot: I haz the power, 2014-06-18 10:05:46]

Change committed as 278007