Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: remoting/jingle_glue/socket_util.cc

Issue 339503006: Update error-handling logic in ChromiumPacketSocketFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/jingle_glue/socket_util.h ('k') | remoting/remoting_srcs.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/socket_util.cc
diff --git a/remoting/jingle_glue/socket_util.cc b/remoting/jingle_glue/socket_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..50e945dd67f1d49844eb1b5e223e3fe384b22f16
--- /dev/null
+++ b/remoting/jingle_glue/socket_util.cc
@@ -0,0 +1,42 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/jingle_glue/socket_util.h"
+
+#include "net/base/net_errors.h"
+
+namespace remoting {
+
+SocketErrorAction GetSocketErrorAction(int error) {
+ switch (error) {
+ // UDP is connectionless, so we may receive ICMP unreachable or reset errors
+ // for previous sends to different addresses.
+ case net::ERR_ADDRESS_UNREACHABLE:
+ case net::ERR_CONNECTION_RESET:
+ return SOCKET_ERROR_ACTION_RETRY;
+
+ // Target address is invalid. The socket is still usable for different
+ // target addresses and the error can be ignored.
+ case net::ERR_ADDRESS_INVALID:
+ return SOCKET_ERROR_ACTION_IGNORE;
+
+ // May be returned when the packet is blocked by local firewall (see
+ // https://code.google.com/p/webrtc/issues/detail?id=1207). The firewall may
+ // still allow us to send to other addresses, so ignore the error for this
+ // particular send.
+ case net::ERR_ACCESS_DENIED:
+ return SOCKET_ERROR_ACTION_IGNORE;
+
+ // Indicates that the buffer in the network adapter is full, so drop this
+ // packet and assume the socket is still usable.
+ case net::ERR_OUT_OF_MEMORY:
+ return SOCKET_ERROR_ACTION_IGNORE;
+
+ default:
+ return SOCKET_ERROR_ACTION_FAIL;
+ }
+}
+
+
+} // namespace remoting
« no previous file with comments | « remoting/jingle_glue/socket_util.h ('k') | remoting/remoting_srcs.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698