Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 339493005: Move more methods into implementation specific timeline UI utils (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Move more methods into implementation specific timeline UI utils BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -388 lines) Patch
M LayoutTests/inspector/timeline/timeline-node-reference.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-id.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +3 lines, -16 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 4 chunks +22 lines, -349 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 2 chunks +364 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 3 chunks +2 lines, -13 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
6 years, 6 months ago (2014-06-18 13:39:21 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-18 14:17:33 UTC) #2
yurys
6 years, 6 months ago (2014-06-18 14:24:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r176421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698