Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 339493005: Move more methods into implementation specific timeline UI utils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 55fe678d06dc7631bff20bfcb418831bc9d97447..4169dd815ab90a3b2c185f89ed8ecef8ddb5b900 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -89,7 +89,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
return WebInspector.UIString("CPU");
else if (record === this._gpuThreadRecord)
return WebInspector.UIString("GPU");
- var details = WebInspector.TimelineUIUtils.buildDetailsNode(record, this._linkifier, this._model.loadedFromFile());
+ var details = WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, this._linkifier, this._model.loadedFromFile());
return details ? WebInspector.UIString("%s (%s)", record.title(), details.textContent) : record.title();
},
@@ -499,7 +499,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
{
var event = this._entryEvents[entryIndex];
if (event) {
- var name = WebInspector.TimelineUIUtils.styleForTimelineEvent(event.name).title;
+ var name = WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name).title;
// TODO(yurys): support event dividers
var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier, false, this._target);
return details ? WebInspector.UIString("%s (%s)", name, details.textContent) : name;
@@ -621,7 +621,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
var event = this._entryEvents[entryIndex];
if (!event)
return "#555";
- var style = WebInspector.TimelineUIUtils.styleForTimelineEvent(event.name);
+ var style = WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name);
return style.category.fillColorStop1;
},
« no previous file with comments | « LayoutTests/inspector/timeline/timeline-script-id.html ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698