Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 339493005: Move more methods into implementation specific timeline UI utils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TracingTimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineModel.js b/Source/devtools/front_end/timeline/TracingTimelineModel.js
index abdc4d08192881768af78fb795e77698aa031d70..b9769678e7f29ff695b735fe149198f776024fe5 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineModel.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineModel.js
@@ -463,17 +463,6 @@ WebInspector.TracingTimelineModel.prototype = {
return null;
},
- /**
- * @param {!WebInspector.TimelineModel.Record} record
- * @return {!WebInspector.TracingModel.Event}
- */
- traceEventFrom: function(record)
- {
- if (!(record instanceof WebInspector.TracingTimelineModel.TraceEventRecord))
- throw new Error("Illegal argument.");
- return record._event;
- },
-
__proto__: WebInspector.TimelineModel.prototype
}
@@ -544,7 +533,7 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
*/
category: function()
{
- var style = WebInspector.TimelineUIUtils.styleForTimelineEvent(this._event.name);
+ var style = WebInspector.TracingTimelineUIUtils.styleForTraceEvent(this._event.name);
return style.category;
},
@@ -553,7 +542,7 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
*/
title: function()
{
- return WebInspector.TimelineUIUtils.recordTitle(this, this._model);
+ return WebInspector.TracingTimelineUIUtils.styleForTraceEvent(this._event.name).title;
},
/**
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698