Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 339493002: Remove redundant calls to FrameLoader::frameDetached(). (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, krit, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove redundant calls to FrameLoader::frameDetached(). Page::willBeDestroyed() detachs any frames remaining in the frame tree, so there's no need to do this before calling willBeDestroyed(). In addition, since frameDetached() recursively detaches all frames, eliminate the loop inside Page::willBeDestroyed() to detach all frames. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176173

Patch Set 1 #

Patch Set 2 : Fix layout tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Theoretically, frame detach is recursive as well, so the loop inside Page shouldn't be needed, ...
6 years, 6 months ago (2014-06-16 00:02:32 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-16 03:05:23 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 6 months ago (2014-06-16 03:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/339493002/20001
6 years, 6 months ago (2014-06-16 03:57:37 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 04:59:29 UTC) #5
Message was sent while issue was closed.
Change committed as 176173

Powered by Google App Engine
This is Rietveld 408576698