Source/web/WebPagePopupImpl.cpp - Issue 339493002: Remove redundant calls to FrameLoader::frameDetached().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 339493002: Remove redundant calls to FrameLoader::frameDetached(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix layout tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index a2a819e762dc29490474208641bc528fc7caed1f..1b833a8d8319ba54eb72241dac19b3f0c4efea8b 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -238,9 +238,6 @@ void WebPagePopupImpl::destroyPage()

if (!m_page)

return;

- if (m_page->mainFrame())

- toLocalFrame(m_page->mainFrame())->loader().frameDetached();

m_page->willBeDestroyed();

m_page.clear();

}

« no previous file with comments | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »