Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 339493002: Remove redundant calls to FrameLoader::frameDetached(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix layout tests. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorOverlay.cpp
diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp
index 49db833ed3a6e9fce57444859224a0a765dec834..b6cf1df77bbb7c6745b7b6df74ea9e27f1f4b91a 100644
--- a/Source/core/inspector/InspectorOverlay.cpp
+++ b/Source/core/inspector/InspectorOverlay.cpp
@@ -774,9 +774,6 @@ bool InspectorOverlay::getBoxModel(Node* node, Vector<FloatQuad>* quads)
void InspectorOverlay::freePage()
{
if (m_overlayPage) {
- // FIXME: This logic is duplicated in SVGImage and WebViewImpl. Perhaps it can be combined
- // into Page's destructor.
- toLocalFrame(m_overlayPage->mainFrame())->loader().frameDetached();
m_overlayPage->willBeDestroyed();
m_overlayPage.clear();
}
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698