Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 3389015: Merge 58902 - Fix bug where window.open() with no feature string from... (Closed)

Created:
10 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 58902 - Fix bug where window.open() with no feature string from extension background pages created a new browser instead of a tab. BUG=54768 TEST= Review URL: http://codereview.chromium.org/3352009 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/background.html View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/content_script.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/foo.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/pop.js View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/tab.html View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/open_popup.html View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/open_tab.html View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/popup.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/tab.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
10 years, 3 months ago (2010-09-16 22:01:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698