Fix bug where window.open() with no feature string from

Fix bug where window.open() with no feature string from
extension background pages created a new browser instead of a
tab.

BUG=54768
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58902

[Matt Perry, 2010-09-08 21:42:39]

LGTM. My only complaint is that "popup_blocking" sounds like you're testing that
popups are blocked, but it's not a big deal.

http://codereview.chromium.org/3352009/diff/5001/6003
File
chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/background.html
(right):

http://codereview.chromium.org/3352009/diff/5001/6003#newcode39
chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/background.html:39:
// OK, we appear to be done with the test. now check that each of the tabs
nit: Now*

http://codereview.chromium.org/3352009/diff/5001/6003#newcode63
chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/background.html:63:
// Open a popup from the background page.
nit: this really opens 2 popups, right?

[Erik does not do reviews, 2010-09-09 17:33:44]

random drive-by nit

http://codereview.chromium.org/3352009/diff/5001/6001
File chrome/browser/extensions/window_open_apitest.cc (right):

http://codereview.chromium.org/3352009/diff/5001/6001#newcode43
chrome/browser/extensions/window_open_apitest.cc:43: std::string
app_base("http://a.com:1337/files/extensions/api_test/"
you're apparently supposed to get the port from the test server dynamically
rather than hard-coding it. (just saw this from Pawel in another review)