Issue 338833004: Revert 276827 "readability review for luken"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338833004: Revert 276827 "readability review for luken" (Closed)

Created:
6 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 6 months ago

Reviewers:
luken

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 276827 "readability review for luken" This is crashing for our canary users on Windows BUG=384736 > readability review for luken > > original code review at: > https://codereview.chromium.org/245763002/ > > Review URL: https://codereview.chromium.org/269513002 TBR=luken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277532

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+754 lines, -1746 lines)			Patch
M	trunk/src/ui/gfx/geometry/r_tree.h	View	2 chunks	+243 lines, -127 lines	0 comments	Download
A +	trunk/src/ui/gfx/geometry/r_tree.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/ui/gfx/geometry/r_tree_base.h	View	1 chunk	+0 lines, -309 lines	0 comments	Download
D	trunk/src/ui/gfx/geometry/r_tree_base.cc	View	1 chunk	+0 lines, -658 lines	0 comments	Download
M	trunk/src/ui/gfx/geometry/r_tree_unittest.cc	View	14 chunks	+500 lines, -637 lines	0 comments	Download
M	trunk/src/ui/gfx/gfx.gyp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/ui/views/view.h	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	trunk/src/ui/views/view.cc	View	6 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r277532.