Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338523004: WebPushClient requires a virtual destructor. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

WebPushClient requires a virtual destructor. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public/platform/WebPushClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mlamouri (slow - plz ping)
6 years, 6 months ago (2014-06-13 15:07:05 UTC) #1
mlamouri (slow - plz ping)
Michael and Kent-san, could you review that CL please? :)
6 years, 6 months ago (2014-06-13 15:07:54 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 6 months ago (2014-06-13 15:09:44 UTC) #3
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-13 17:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/338523004/1
6 years, 6 months ago (2014-06-13 17:45:30 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 18:54:54 UTC) #6
Message was sent while issue was closed. 
Change committed as 176124

Powered by Google App Engine
This is Rietveld 408576698