public/platform/WebPushClient.h - Issue 338523004: WebPushClient requires a virtual destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebPushClient.h

Issue 338523004: WebPushClient requires a virtual destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/platform/WebPushClient.h

diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h

index ad687680a2e6d78e22eb34d9b99e67c440933af1..134f44591cf2a42c91d53cc09baa0981de870d33 100644

--- a/public/platform/WebPushClient.h

+++ b/public/platform/WebPushClient.h

@@ -17,6 +17,7 @@ typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallb

class WebPushClient {

public:

+ virtual ~WebPushClient() { }

virtual void registerPushMessaging(const WebString& senderId, WebPushRegistrationCallbacks*) = 0;

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »