Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: public/platform/WebPushClient.h

Issue 338523004: WebPushClient requires a virtual destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebPushClient_h 5 #ifndef WebPushClient_h
6 #define WebPushClient_h 6 #define WebPushClient_h
7 7
8 #include "public/platform/WebCallbacks.h" 8 #include "public/platform/WebCallbacks.h"
9 #include "public/platform/WebPushError.h" 9 #include "public/platform/WebPushError.h"
10 #include "public/platform/WebString.h" 10 #include "public/platform/WebString.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 struct WebPushRegistration; 14 struct WebPushRegistration;
15 15
16 typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallb acks; 16 typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallb acks;
17 17
18 class WebPushClient { 18 class WebPushClient {
19 public: 19 public:
20 virtual ~WebPushClient() { }
20 virtual void registerPushMessaging(const WebString& senderId, WebPushRegistr ationCallbacks*) = 0; 21 virtual void registerPushMessaging(const WebString& senderId, WebPushRegistr ationCallbacks*) = 0;
21 }; 22 };
22 23
23 } // namespace blink 24 } // namespace blink
24 25
25 #endif // WebPushClient_h 26 #endif // WebPushClient_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698