Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 338243006: Revert 176298 "[WebSocket] bufferedAmount should not decrease in..." (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
Reviewers:
yhirano
CC:
blink-reviews
Visibility:
Public.

Description

Revert 176298 "[WebSocket] bufferedAmount should not decrease in..." This CL broke browser_tests (WebSocket2): http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151 > [WebSocket] bufferedAmount should not decrease inside a task. > > The spec says that bufferedAmount must not decrease in the task that > send() is called. > Fixed both the new and the old implementation although the old implementaion > is at any rate broken (bufferedAmount in the old implementation includes > the protocol overhead). > > BUG=159563 > > Review URL: https://codereview.chromium.org/311993006 TBR=yhirano@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -214 lines) Patch
D trunk/LayoutTests/http/tests/websocket/bufferedAmount-after-send.html View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/LayoutTests/http/tests/websocket/bufferedAmount-after-send-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/Source/modules/websockets/MainThreadWebSocketChannel.h View 5 chunks +3 lines, -24 lines 0 comments Download
M trunk/Source/modules/websockets/MainThreadWebSocketChannel.cpp View 5 chunks +14 lines, -31 lines 0 comments Download
M trunk/Source/modules/websockets/NewWebSocketChannelImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/Source/modules/websockets/NewWebSocketChannelImpl.cpp View 8 chunks +12 lines, -7 lines 0 comments Download
M trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M trunk/Source/modules/websockets/WebSocket.h View 4 chunks +2 lines, -7 lines 0 comments Download
M trunk/Source/modules/websockets/WebSocket.cpp View 8 chunks +7 lines, -25 lines 0 comments Download
M trunk/Source/modules/websockets/WebSocketChannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/modules/websockets/WebSocketChannelClient.h View 1 chunk +17 lines, -17 lines 0 comments Download
M trunk/Source/modules/websockets/WebSocketTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 8 chunks +49 lines, -8 lines 0 comments Download
M trunk/Source/platform/network/SocketStreamHandle.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/platform/network/SocketStreamHandle.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M trunk/Source/platform/network/SocketStreamHandleClient.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/web/WebSocketImpl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/Source/web/WebSocketImpl.cpp View 5 chunks +5 lines, -9 lines 0 comments Download
M trunk/public/web/WebSocketClient.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 6 months ago (2014-06-17 12:54:46 UTC) #1
haraken
6 years, 6 months ago (2014-06-17 12:55:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r176311.

Powered by Google App Engine
This is Rietveld 408576698