trunk/Source/modules/websockets/WebSocketTest.cpp - Issue 338243006: Revert 176298 "[WebSocket] bufferedAmount should not decrease in..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/modules/websockets/WebSocketTest.cpp

Issue 338243006: Revert 176298 "[WebSocket] bufferedAmount should not decrease in..." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/Source/modules/websockets/WebSocketChannelClient.h ('k') | trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/Source/modules/websockets/WebSocketTest.cpp

===================================================================

--- trunk/Source/modules/websockets/WebSocketTest.cpp (revision 176310)

+++ trunk/Source/modules/websockets/WebSocketTest.cpp (working copy)

@@ -116,7 +116,7 @@

::testing::Mock::VerifyAndClear(m_websocket->channel());

EXPECT_CALL(channel(), disconnect()).Times(AnyNumber());

- m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

+ m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

m_websocket.clear();

Heap::collectAllGarbage();

}

@@ -294,7 +294,7 @@

EXPECT_FALSE(m_exceptionState.hadException());

EXPECT_EQ(WebSocket::CONNECTING, m_websocket->readyState());

- m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

+ m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

EXPECT_EQ(WebSocket::CLOSED, m_websocket->readyState());

}

@@ -463,7 +463,7 @@

EXPECT_FALSE(m_exceptionState.hadException());

EXPECT_EQ(WebSocket::CLOSING, m_websocket->readyState());

- m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeComplete, 1000, String());

+ m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeComplete, 1000, String());

EXPECT_EQ(WebSocket::CLOSED, m_websocket->readyState());

m_websocket->close(m_exceptionState);

@@ -523,7 +523,7 @@

EXPECT_FALSE(m_exceptionState.hadException());

- m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

+ m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

checkpoint.Call(1);

m_websocket->send("hello", m_exceptionState);

@@ -642,7 +642,7 @@

EXPECT_FALSE(m_exceptionState.hadException());

- m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

+ m_websocket->didClose(0, WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

checkpoint.Call(1);

m_websocket->send(view->buffer().get(), m_exceptionState);