Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: trunk/Source/modules/websockets/WebSocket.h

Issue 338243006: Revert 176298 "[WebSocket] bufferedAmount should not decrease in..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/Source/modules/websockets/WebSocket.h
===================================================================
--- trunk/Source/modules/websockets/WebSocket.h (revision 176310)
+++ trunk/Source/modules/websockets/WebSocket.h (working copy)
@@ -120,9 +120,9 @@
virtual void didReceiveMessage(const String& message) OVERRIDE;
virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> >) OVERRIDE;
virtual void didReceiveMessageError() OVERRIDE;
- virtual void didConsumeBufferedAmount(unsigned long) OVERRIDE;
+ virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) OVERRIDE;
virtual void didStartClosingHandshake() OVERRIDE;
- virtual void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;
+ virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;
virtual void trace(Visitor*) OVERRIDE;
@@ -208,7 +208,6 @@
// Updates m_bufferedAmountAfterClose given the amount of data passed to
// send() method after the state changed to CLOSING or CLOSED.
void updateBufferedAmountAfterClose(unsigned long);
- void reflectBufferedAmountConsumption(Timer<WebSocket>*);
void releaseChannel();
@@ -222,9 +221,6 @@
State m_state;
KURL m_url;
unsigned long m_bufferedAmount;
- // The consumed buffered amount that will be reflected to m_bufferedAmount
- // later. It will be cleared once reflected.
- unsigned long m_consumedBufferedAmount;
unsigned long m_bufferedAmountAfterClose;
BinaryType m_binaryType;
// The subprotocol the server selected.
@@ -232,7 +228,6 @@
String m_extensions;
RefPtrWillBeMember<EventQueue> m_eventQueue;
- Timer<WebSocket> m_bufferedAmountConsumeTimer;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698