Certificate Transparency: Switch to using a generated CT log list

net/cert/multi_log_ct_verifier.h

Index: net/cert/multi_log_ct_verifier.h
diff --git a/net/cert/multi_log_ct_verifier.h b/net/cert/multi_log_ct_verifier.h
index d70ba4581f5c364fdeae5d44c9202ee32645bd8f..f07bc5751ada5f7f22fe5ea7b94e4ec798751938 100644
--- a/net/cert/multi_log_ct_verifier.h
+++ b/net/cert/multi_log_ct_verifier.h
@@ -33,6 +33,7 @@ class NET_EXPORT MultiLogCTVerifier : public CTVerifier {
   virtual ~MultiLogCTVerifier();
 
   void AddLog(scoped_ptr<CTLogVerifier> log_verifier);
+  void AddLogs(std::vector<linked_ptr<CTLogVerifier> > log_verifiers);

[Ryan Sleevi, 2014/06/17 01:02:04]

Feels like too much coupling here. I dislike the linked_ptr<> bleeding in here.

It should, presumably, be a const-ref arg if passed as vector, although if you
go ScopedVector, and you do intend to ownership transfer, you'd continue
by-value and use the .Pass() semantics (aka C++11 move emulation)

[Eran Messeri, 2014/06/17 17:31:41]

Good point. I've switched to using ScopedVector and take ownership of the
pointers inside the AddLogs method.

 
   // CTVerifier implementation:
   virtual int Verify(X509Certificate* cert,