Certificate Transparency: Switch to using a generated CT log list

net/cert/multi_log_ct_verifier.cc

Index: net/cert/multi_log_ct_verifier.cc
diff --git a/net/cert/multi_log_ct_verifier.cc b/net/cert/multi_log_ct_verifier.cc
index 5094da026d03f38bf8cee4c54c7cea5ce2f32580..947aa2f92a539e550e1bcde8cbb863bea2d3d7e6 100644
--- a/net/cert/multi_log_ct_verifier.cc
+++ b/net/cert/multi_log_ct_verifier.cc
@@ -66,6 +66,17 @@ void MultiLogCTVerifier::AddLog(scoped_ptr<CTLogVerifier> log_verifier) {
   logs_[log->key_id()] = log;
 }
 
+void MultiLogCTVerifier::AddLogs(
+    std::vector<linked_ptr<CTLogVerifier> > log_verifiers) {

[agl, 2014/06/13 00:32:05]

const & for the vector?

[Eran Messeri, 2014/06/17 17:31:41]

Switched to using ScopedVector, see if that makes sense.
As a side note, the reason for creating the CTLogVerifier instances in one place
and taking ownership of them here is that (1) their creation is separated from
the implementation of the MultiLogCTVerifier and (2) should these classes grow
to contain additional log information (like latest tree head), there could be
multiple instances of them in different parts of Chrome that do not share state
(I understand it's good practice not to mix state between the different profiles
and the system context).

+  for (std::vector<linked_ptr<CTLogVerifier> >::iterator it =
+       log_verifiers.begin(); it != log_verifiers.end(); ++it) {
+    linked_ptr<CTLogVerifier> log(*it);
+    VLOG(1) << "Adding CT log: " << log->description();
+    logs_[log->key_id()] = log;
+  }
+}
+

[agl, 2014/06/13 00:32:05]

extra space?

[Eran Messeri, 2014/06/17 17:31:41]

Done, removed.

+
 int MultiLogCTVerifier::Verify(
     X509Certificate* cert,
     const std::string& stapled_ocsp_response,