Certificate Transparency: Switch to using a generated CT log list

net/cert/multi_log_ct_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_MULTI_LOG_CT_VERIFIER_H_
 #define NET_CERT_MULTI_LOG_CT_VERIFIER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 15 matching lines @@
 // Timestamps from multiple logs.
 // There should be a global instance of this class and for all known logs,
 // AddLog should be called with a CTLogVerifier (which is created from the
 // log's public key).
 class NET_EXPORT MultiLogCTVerifier : public CTVerifier {
  public:
   MultiLogCTVerifier();
   virtual ~MultiLogCTVerifier();
 
   void AddLog(scoped_ptr<CTLogVerifier> log_verifier);
+  void AddLogs(std::vector<linked_ptr<CTLogVerifier> > log_verifiers);

[Ryan Sleevi, 2014/06/17 01:02:04]

Feels like too much coupling here. I dislike the linked_ptr<> bleeding in here.

It should, presumably, be a const-ref arg if passed as vector, although if you
go ScopedVector, and you do intend to ownership transfer, you'd continue
by-value and use the .Pass() semantics (aka C++11 move emulation)

[Eran Messeri, 2014/06/17 17:31:41]

Good point. I've switched to using ScopedVector and take ownership of the
pointers inside the AddLogs method.

 
   // CTVerifier implementation:
   virtual int Verify(X509Certificate* cert,
                      const std::string& stapled_ocsp_response,
                      const std::string& sct_list_from_tls_extension,
                      ct::CTVerifyResult* result,
                      const BoundNetLog& net_log) OVERRIDE;
 
  private:
   // Mapping from a log's ID to the verifier for this log.
@@ skipping 16 matching lines @@
       ct::CTVerifyResult* result);
 
   IDToLogMap logs_;
 
   DISALLOW_COPY_AND_ASSIGN(MultiLogCTVerifier);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_MULTI_LOG_CT_VERIFIER_H_