Certificate Transparency: Switch to using a generated CT log list

net/cert/multi_log_ct_verifier.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/multi_log_ct_verifier.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/metrics/histogram.h"
 #include "net/base/net_errors.h"
@@ skipping 48 matching lines @@
 
 void MultiLogCTVerifier::AddLog(scoped_ptr<CTLogVerifier> log_verifier) {
   DCHECK(log_verifier);
   if (!log_verifier)
     return;
 
   linked_ptr<CTLogVerifier> log(log_verifier.release());
   logs_[log->key_id()] = log;
 }
 
+void MultiLogCTVerifier::AddLogs(
+    std::vector<linked_ptr<CTLogVerifier> > log_verifiers) {

[agl, 2014/06/13 00:32:05]

const & for the vector?

[Eran Messeri, 2014/06/17 17:31:41]

Switched to using ScopedVector, see if that makes sense.
As a side note, the reason for creating the CTLogVerifier instances in one place
and taking ownership of them here is that (1) their creation is separated from
the implementation of the MultiLogCTVerifier and (2) should these classes grow
to contain additional log information (like latest tree head), there could be
multiple instances of them in different parts of Chrome that do not share state
(I understand it's good practice not to mix state between the different profiles
and the system context).

+  for (std::vector<linked_ptr<CTLogVerifier> >::iterator it =
+       log_verifiers.begin(); it != log_verifiers.end(); ++it) {
+    linked_ptr<CTLogVerifier> log(*it);
+    VLOG(1) << "Adding CT log: " << log->description();
+    logs_[log->key_id()] = log;
+  }
+}
+

[agl, 2014/06/13 00:32:05]

extra space?

[Eran Messeri, 2014/06/17 17:31:41]

Done, removed.

+
 int MultiLogCTVerifier::Verify(
     X509Certificate* cert,
     const std::string& stapled_ocsp_response,
     const std::string& sct_list_from_tls_extension,
     ct::CTVerifyResult* result,
     const BoundNetLog& net_log)  {
   DCHECK(cert);
   DCHECK(result);
 
   result->verified_scts.clear();
@@ skipping 133 matching lines @@
     LogSCTStatusToUMA(ct::SCT_STATUS_INVALID);
     return false;
   }
 
   LogSCTStatusToUMA(ct::SCT_STATUS_OK);
   result->verified_scts.push_back(sct);
   return true;
 }
 
 } // namespace net