Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 33753002: Sooper experimental refactoring of the profile info cache.

Created:
7 years, 2 months ago by noms (inactive)
Modified:
7 years, 1 month ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Sooper experimental refactoring of the profile info cache. Do not pass go, do not collect $200. Definitely do not commit this. Based on Sailesh's first try at refactoring it, http://codereview.chromium.org/8539043/ BUG=305720

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1090 lines, -714 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 5 chunks +25 lines, -14 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 1 4 chunks +10 lines, -28 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_actions_desktop.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_desktop.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 2 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +12 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 1 6 chunks +105 lines, -50 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 14 chunks +454 lines, -384 lines 0 comments Download
A chrome/browser/profiles/profile_info_entry.h View 1 chunk +110 lines, -0 lines 0 comments Download
A chrome/browser/profiles/profile_info_entry.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_interface.h View 1 2 chunks +35 lines, -19 lines 0 comments Download
M chrome/browser/profiles/profile_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop.cc View 2 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 4 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 chunk +19 lines, -15 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 5 chunks +22 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_names_io_thread.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_util.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/profile_chooser_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 8 chunks +31 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_import_handler.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 4 chunks +29 lines, -28 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698