Sooper experimental refactoring of the profile info cache.

chrome/browser/ui/sync/one_click_signin_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 #include <vector>
@@ skipping 721 matching lines @@
     }
 
     // If some profile, not just the current one, is already connected to this
     // account, don't show the infobar.
     if (g_browser_process && !same_email) {
       ProfileManager* manager = g_browser_process->profile_manager();
       if (manager) {
         string16 email16 = UTF8ToUTF16(email);
         ProfileInfoCache& cache = manager->GetProfileInfoCache();
 
-        for (size_t i = 0; i < cache.GetNumberOfProfiles(); ++i) {
-          if (email16 == cache.GetUserNameOfProfileAtIndex(i)) {
+        const std::vector<ProfileInfoEntry> entries(cache.GetProfilesSortedByName());
+        for (std::vector<ProfileInfoEntry>::const_iterator it = entries.begin();
+          it != entries.end(); ++it) {
+          if (email16 == it->user_name()) {
             if (error_message) {
               error_message->assign(
                   l10n_util::GetStringUTF8(IDS_SYNC_USER_NAME_IN_USE_ERROR));
             }
             return false;
           }
         }
       }
     }
 
@@ skipping 711 matching lines @@
     // If the web contents is showing a blank page and not about to be closed,
     // redirect to the NTP or apps page.
     if (signin::IsContinueUrlForWebBasedSigninFlow(current_url) &&
         !signin::IsAutoCloseEnabledInURL(original_continue_url_)) {
       RedirectToNtpOrAppsPage(
           web_contents(),
           signin::GetSourceForPromoURL(original_continue_url_));
     }
   }
 }