Source/modules/filesystem/InspectorFileSystemAgent.cpp - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/filesystem/InspectorFileSystemAgent.cpp

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/filesystem/InspectorFileSystemAgent.cpp

diff --git a/Source/modules/filesystem/InspectorFileSystemAgent.cpp b/Source/modules/filesystem/InspectorFileSystemAgent.cpp

index aaeffbc30e6afee24745364b65f52a11eaad2277..bb8f5f6f7dfa3cf0abf04fd9d84710bfa10456bb 100644

--- a/Source/modules/filesystem/InspectorFileSystemAgent.cpp

+++ b/Source/modules/filesystem/InspectorFileSystemAgent.cpp

@@ -472,7 +472,7 @@ bool FileContentRequest::didGetEntry(Entry* entry)

bool FileContentRequest::didGetFile(File* file)

{

- RefPtrWillBeRawPtr<Blob> blob = static_cast<Blob*>(file)->slice(m_start, m_end, IGNORE_EXCEPTION);

+ RefPtrWillBeRawPtr<Blob> blob = static_cast<Blob*>(file)->slice(m_start, makeOptional(m_end), String(), IGNORE_EXCEPTION);

m_reader->setOnload(this);

m_reader->setOnerror(this);

« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationEvent.idl ('k') | Source/modules/gamepad/GamepadList.idl » ('j') | no next file with comments »