Source/modules/device_orientation/DeviceOrientationEvent.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationEvent.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceMotionEvent.idl ('k') | Source/modules/filesystem/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationEvent.idl

diff --git a/Source/modules/device_orientation/DeviceOrientationEvent.idl b/Source/modules/device_orientation/DeviceOrientationEvent.idl

index 00e9d0476c40e3d95d6aa5c5ec68cb3ea8e56b3b..4ef0b14c1f6225eda28fe9a58bbd825b8d8a38d6 100644

--- a/Source/modules/device_orientation/DeviceOrientationEvent.idl

+++ b/Source/modules/device_orientation/DeviceOrientationEvent.idl

@@ -28,11 +28,11 @@ interface DeviceOrientationEvent : Event {

readonly attribute double? beta;

readonly attribute double? gamma;

readonly attribute boolean? absolute;

- [Custom] void initDeviceOrientationEvent([Default=Undefined] optional DOMString type,

- [Default=Undefined] optional boolean bubbles,

- [Default=Undefined] optional boolean cancelable,

- [Default=Undefined] optional double alpha,

- [Default=Undefined] optional double beta,

- [Default=Undefined] optional double gamma,

- [Default=Undefined] optional boolean absolute);

+ [Custom] void initDeviceOrientationEvent(optional DOMString type,

+ optional boolean bubbles,

+ optional boolean cancelable,

+ optional double alpha,

+ optional double beta,

+ optional double gamma,

+ optional boolean absolute);

};

« no previous file with comments | « Source/modules/device_orientation/DeviceMotionEvent.idl ('k') | Source/modules/filesystem/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »