Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: Source/modules/filesystem/InspectorFileSystemAgent.cpp

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 toFileEntry(entry)->file(successCallback.release(), errorCallback.release()) ; 465 toFileEntry(entry)->file(successCallback.release(), errorCallback.release()) ;
466 466
467 m_reader = FileReader::create(entry->filesystem()->executionContext()); 467 m_reader = FileReader::create(entry->filesystem()->executionContext());
468 m_mimeType = MIMETypeRegistry::getMIMETypeForPath(entry->name()); 468 m_mimeType = MIMETypeRegistry::getMIMETypeForPath(entry->name());
469 469
470 return true; 470 return true;
471 } 471 }
472 472
473 bool FileContentRequest::didGetFile(File* file) 473 bool FileContentRequest::didGetFile(File* file)
474 { 474 {
475 RefPtrWillBeRawPtr<Blob> blob = static_cast<Blob*>(file)->slice(m_start, m_e nd, IGNORE_EXCEPTION); 475 RefPtrWillBeRawPtr<Blob> blob = static_cast<Blob*>(file)->slice(m_start, mak eOptional(m_end), String(), IGNORE_EXCEPTION);
476 m_reader->setOnload(this); 476 m_reader->setOnload(this);
477 m_reader->setOnerror(this); 477 m_reader->setOnerror(this);
478 478
479 m_reader->readAsArrayBuffer(blob.get(), IGNORE_EXCEPTION); 479 m_reader->readAsArrayBuffer(blob.get(), IGNORE_EXCEPTION);
480 return true; 480 return true;
481 } 481 }
482 482
483 void FileContentRequest::didRead() 483 void FileContentRequest::didRead()
484 { 484 {
485 RefPtr<ArrayBuffer> buffer = m_reader->arrayBufferResult(); 485 RefPtr<ArrayBuffer> buffer = m_reader->arrayBufferResult();
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 return 0; 728 return 0;
729 } 729 }
730 730
731 void InspectorFileSystemAgent::trace(Visitor* visitor) 731 void InspectorFileSystemAgent::trace(Visitor* visitor)
732 { 732 {
733 visitor->trace(m_page); 733 visitor->trace(m_page);
734 InspectorBaseAgent::trace(visitor); 734 InspectorBaseAgent::trace(visitor);
735 } 735 }
736 736
737 } // namespace blink 737 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationEvent.idl ('k') | Source/modules/gamepad/GamepadList.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698