Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 337323004: Revert of Some inline ARM assembly for saturated arithmetic, a small speed-up for (Closed)

Created:
6 years, 5 months ago by Timothy Loh
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium, Erik Corry, Chris Evans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Some inline ARM assembly for saturated arithmetic, a small speed-up for (https://codereview.chromium.org/346913004/) Reason for revert: Looks like this isn't compiling on android_clang_dbg (needed for the roll into chromium); reverting for now. http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/157031/steps/compile/logs/stdio Original issue's description: > Some inline ARM assembly for saturated arithmetic and a small speed-up > for the C version of saturated add and subtract. Created a unit test for > setting a saturated value. > > Benchmarking using rasterize_and_record_micro.key_mobile_sites on a > Nexus7 recorded a consistent drop in RasterizeAndRecordMicro:record_time > from 5.18ms to 4.93ms (~5% improvement). > > BUG=325746 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177208 TBR=bulach@chromium.org,skyostil@chromium.org,schenney@chromium.org,picksi@google.com,eseidel@chromium.org,eae@chromium.org,picksi@chromium.org NOTREECHECKS=true NOTRY=true BUG=325746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -222 lines) Patch
M Source/platform/LayoutUnit.h View 1 chunk +13 lines, -6 lines 0 comments Download
M Source/wtf/SaturatedArithmetic.h View 3 chunks +8 lines, -62 lines 0 comments Download
M Source/wtf/SaturatedArithmeticTest.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/wtf/asm/SaturatedArithmeticARM.h View 1 chunk +0 lines, -105 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Timothy Loh
Created Revert of Some inline ARM assembly for saturated arithmetic, a small speed-up for
6 years, 5 months ago (2014-06-30 13:57:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/337323004/1
6 years, 5 months ago (2014-06-30 13:57:58 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 13:58:28 UTC) #3
Message was sent while issue was closed.
Change committed as 177212

Powered by Google App Engine
This is Rietveld 408576698