Remove the ability to retain local data of evicted ephemeral apps

Remove the ability to retain local data of evicted ephemeral apps

This is effectively a revert of http://crrev.com/202763005

BUG=339004
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277972

[tmdiep, 2014-06-17 07:19:28]

I mentioned this briefly in a 1:1. Since we are initially marketing this feature
as "Try", it might not make sense to leave data hanging around for a long time.
Just remove it when the ephemeral app is evicted from the cache.

We can reinstate this feature later if we need it.

[benwells, 2014-06-18 00:21:47]

https://codereview.chromium.org/337323003/diff/20001/chrome/browser/apps/ephe...
File chrome/browser/apps/ephemeral_app_service.h (left):

https://codereview.chromium.org/337323003/diff/20001/chrome/browser/apps/ephe...
chrome/browser/apps/ephemeral_app_service.h:50: static const int
kDataInactiveThreshold;
If we just change the value of this constant, would we get the same behavior but
keep the flexibility of having different timeouts?

[tmdiep, 2014-06-18 01:04:58]

https://codereview.chromium.org/337323003/diff/20001/chrome/browser/apps/ephe...
File chrome/browser/apps/ephemeral_app_service.h (left):

https://codereview.chromium.org/337323003/diff/20001/chrome/browser/apps/ephe...
chrome/browser/apps/ephemeral_app_service.h:50: static const int
kDataInactiveThreshold;
On 2014/06/18 00:21:47, benwells wrote:
> If we just change the value of this constant, would we get the same behavior
but
> keep the flexibility of having different timeouts?

Not identical as the data garbage collection only occurred at startup, but it
can be easily triggered to run when ephemeral apps get evicted as well.

The motivation of reverting the patch was to reduce the complexity of the all
the code changes needed to support it.

[benwells, 2014-06-18 05:36:39]

Please change the description to be something other than 'Revert ....', so
people don't think it is an automatic revert for sheriffing / tree purposes.

Other than that, lgtm.

[tmdiep, 2014-06-18 05:46:33]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-06-18 05:47:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/337323003/20001

[commit-bot: I haz the power, 2014-06-18 07:32:14]

Change committed as 277972