chrome/browser/extensions/extension_service.cc - Issue 337323003: Remove the ability to retain local data of evicted ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 337323003: Remove the ability to retain local data of evicted ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an unused declaration Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/ephemeral_app_service.h ('K') | « chrome/browser/extensions/extension_garbage_collector.cc ('k') | chrome/browser/extensions/extension_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index f3fbae3fb105530508e10ff7e8a99a795449c4f8..0c7114f37714e4019791e9bb7f61e882a4680cac 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -760,10 +760,7 @@ bool ExtensionService::UninstallExtension(

NOTREACHED();

}

- // Do not remove the data of ephemeral apps. They will be garbage collected by

- // EphemeralAppService.

- if (!extension_prefs_->IsEphemeralApp(extension->id()))

- extensions::DataDeleter::StartDeleting(profile_, extension.get());

+ extensions::DataDeleter::StartDeleting(profile_, extension.get());

UntrackTerminatedExtension(extension->id());