Remove the ability to retain local data of evicted ephemeral apps

chrome/browser/apps/ephemeral_app_service.h

Index: chrome/browser/apps/ephemeral_app_service.h
diff --git a/chrome/browser/apps/ephemeral_app_service.h b/chrome/browser/apps/ephemeral_app_service.h
index 94990cae669a10f538990894c34d74a1ef805ef1..ee4b9b1cc752fc8c94448c9f01f310d0d5d0e57c 100644
--- a/chrome/browser/apps/ephemeral_app_service.h
+++ b/chrome/browser/apps/ephemeral_app_service.h
@@ -45,9 +45,6 @@ class EphemeralAppService : public KeyedService,
   static const int kAppKeepThreshold;
   // The maximum number of ephemeral apps to keep cached. Excess may be removed.
   static const int kMaxEphemeralAppsCount;
-  // The number of days of inactivity before the data of an already evicted
-  // ephemeral app will be removed.
-  static const int kDataInactiveThreshold;

[benwells, 2014/06/18 00:21:47]

If we just change the value of this constant, would we get the same behavior but
keep the flexibility of having different timeouts?

[tmdiep, 2014/06/18 01:04:57]

Not identical as the data garbage collection only occurred at startup, but it
can be easily triggered to run when ephemeral apps get evicted as well.

The motivation of reverting the patch was to reduce the complexity of the all
the code changes needed to support it.

 
  private:
   // A map used to order the ephemeral apps by their last launch time.
@@ -79,25 +76,18 @@ class EphemeralAppService : public KeyedService,
                               const LaunchTimeAppMap& app_launch_times,
                               std::set<std::string>* remove_app_ids);
 
-  // Garbage collect the data of ephemeral apps that have been evicted and
-  // inactive for a long period of time.
-  void GarbageCollectData();
-
   Profile* profile_;
 
   content::NotificationRegistrar registrar_;
-
   ScopedObserver<extensions::ExtensionRegistry,
                  extensions::ExtensionRegistryObserver>
       extension_registry_observer_;
 
   base::OneShotTimer<EphemeralAppService> garbage_collect_apps_timer_;
-  base::OneShotTimer<EphemeralAppService> garbage_collect_data_timer_;
 
   // The count of cached ephemeral apps.
   int ephemeral_app_count_;
 
-  friend class EphemeralAppBrowserTest;
   friend class EphemeralAppServiceTest;
   friend class EphemeralAppServiceBrowserTest;