Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337113005: Reduce forward declarations in core/rendering (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
adamk, eseidel
CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chromiumbugtracker_adobe.com, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., philipj_slow, rune+blink, Stephen Chennney, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reduce forward declarations in core/rendering BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -107 lines) Patch
M Source/core/rendering/FilterEffectRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/HitTestLocation.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/rendering/LayoutState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBR.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderButton.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderIFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerStackingNodeIterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMediaControls.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderRegion.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProvider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/line/LineLayoutState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/line/LineWidth.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/style/KeyframeList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/SVGRenderStyle.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/SVGRenderStyleDefs.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineFlowBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGMarkerData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngineSpacing.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL
6 years, 6 months ago (2014-06-18 19:56:30 UTC) #1
adamk
lgtm I'm curious, was this created with an automated script?
6 years, 6 months ago (2014-06-18 20:02:35 UTC) #2
rwlbuis
On 2014/06/18 20:02:35, adamk wrote: > lgtm > > I'm curious, was this created with ...
6 years, 6 months ago (2014-06-18 20:23:50 UTC) #3
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 6 months ago (2014-06-18 20:23:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/337113005/1
6 years, 6 months ago (2014-06-18 20:24:48 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 22:41:38 UTC) #6
Message was sent while issue was closed. 
Change committed as 176458

Powered by Google App Engine
This is Rietveld 408576698