Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336303002: Fix HTMLMediaElement to always use the 'effective playback rate' (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 6 months ago
Reviewers:
philipj_slow, adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix HTMLMediaElement to always use the 'effective playback rate' Explicitly introduce the "effective playback rate" concept in the HTML5 spec and use it to make sure the MediaController's playback rate is always used when a controller is attached. BUG=385408 TEST=LayoutTests/media/media-controller-effective-playback-rate.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176344

Patch Set 1 : Test #

Total comments: 4

Patch Set 2 : Rebase and address CR comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
A LayoutTests/media/media-controller-effective-playback-rate.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/media/media-controller-effective-playback-rate-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 6 months ago (2014-06-17 01:00:09 UTC) #1
adamk
lgtm
6 years, 6 months ago (2014-06-17 01:05:34 UTC) #2
philipj_slow
LGTM with bikeshedding. https://codereview.chromium.org/336303002/diff/20001/LayoutTests/media/media-controller-effective-playback-rate.html File LayoutTests/media/media-controller-effective-playback-rate.html (right): https://codereview.chromium.org/336303002/diff/20001/LayoutTests/media/media-controller-effective-playback-rate.html#newcode22 LayoutTests/media/media-controller-effective-playback-rate.html:22: video.mediaGroup = "group"; Just video.controller = ...
6 years, 6 months ago (2014-06-17 12:10:54 UTC) #3
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/336303002/diff/20001/LayoutTests/media/media-controller-effective-playback-rate.html File LayoutTests/media/media-controller-effective-playback-rate.html (right): https://codereview.chromium.org/336303002/diff/20001/LayoutTests/media/media-controller-effective-playback-rate.html#newcode22 LayoutTests/media/media-controller-effective-playback-rate.html:22: video.mediaGroup = "group"; On 2014/06/17 12:10:54, philipj wrote: > ...
6 years, 6 months ago (2014-06-17 16:55:18 UTC) #4
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 6 months ago (2014-06-17 16:55:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/336303002/40001
6 years, 6 months ago (2014-06-17 16:55:39 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 18:28:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 176344

Powered by Google App Engine
This is Rietveld 408576698