Source/core/html/HTMLMediaElement.h - Issue 336303002: Fix HTMLMediaElement to always use the 'effective playback rate'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 336303002: Fix HTMLMediaElement to always use the 'effective playback rate' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase and address CR comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/media-controller-effective-playback-rate-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 884cc68136230ef2a858eccf50090f53ae50ffb4..b8a033b08f996f10b1b91e99d2b4c73945390fe6 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -451,6 +451,9 @@ private:

enum DirectionOfPlayback { Backward, Forward };

DirectionOfPlayback directionOfPlayback() const;

+ // Returns the "effective playback rate" value as specified in the HTML5 spec.

+ double effectivePlaybackRate() const;

// Creates placeholder AudioTrack and/or VideoTrack objects when WebMemediaPlayer objects

// advertise they have audio and/or video, but don't explicitly signal them via

// addAudioTrack() and addVideoTrack().

« no previous file with comments | « LayoutTests/media/media-controller-effective-playback-rate-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »