Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/html/HTMLMediaElement.h

Issue 336303002: Fix HTMLMediaElement to always use the 'effective playback rate' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase and address CR comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 bool isBlocked() const; 444 bool isBlocked() const;
445 bool isBlockedOnMediaController() const; 445 bool isBlockedOnMediaController() const;
446 bool isAutoplaying() const { return m_autoplaying; } 446 bool isAutoplaying() const { return m_autoplaying; }
447 447
448 blink::WebMediaPlayer::CORSMode corsMode() const; 448 blink::WebMediaPlayer::CORSMode corsMode() const;
449 449
450 // Returns the "direction of playback" value as specified in the HTML5 spec. 450 // Returns the "direction of playback" value as specified in the HTML5 spec.
451 enum DirectionOfPlayback { Backward, Forward }; 451 enum DirectionOfPlayback { Backward, Forward };
452 DirectionOfPlayback directionOfPlayback() const; 452 DirectionOfPlayback directionOfPlayback() const;
453 453
454 // Returns the "effective playback rate" value as specified in the HTML5 spe c.
455 double effectivePlaybackRate() const;
456
454 // Creates placeholder AudioTrack and/or VideoTrack objects when WebMemediaP layer objects 457 // Creates placeholder AudioTrack and/or VideoTrack objects when WebMemediaP layer objects
455 // advertise they have audio and/or video, but don't explicitly signal them via 458 // advertise they have audio and/or video, but don't explicitly signal them via
456 // addAudioTrack() and addVideoTrack(). 459 // addAudioTrack() and addVideoTrack().
457 // FIXME: Remove this once all WebMediaPlayer implementations properly repor t their track info. 460 // FIXME: Remove this once all WebMediaPlayer implementations properly repor t their track info.
458 void createPlaceholderTracksIfNecessary(); 461 void createPlaceholderTracksIfNecessary();
459 462
460 // Sets the selected/enabled tracks if they aren't set before we initially 463 // Sets the selected/enabled tracks if they aren't set before we initially
461 // transition to HAVE_METADATA. 464 // transition to HAVE_METADATA.
462 void selectInitialTracksIfNecessary(); 465 void selectInitialTracksIfNecessary();
463 466
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 inline bool isHTMLMediaElement(const HTMLElement& element) 622 inline bool isHTMLMediaElement(const HTMLElement& element)
620 { 623 {
621 return isHTMLAudioElement(element) || isHTMLVideoElement(element); 624 return isHTMLAudioElement(element) || isHTMLVideoElement(element);
622 } 625 }
623 626
624 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement); 627 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
625 628
626 } //namespace 629 } //namespace
627 630
628 #endif 631 #endif
OLDNEW
« no previous file with comments | « LayoutTests/media/media-controller-effective-playback-rate-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698