Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3500)

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 335893002: Support to remove passwords by date_synced timestamp. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync integration tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index 3882ba03295e87160b6f515f78172946a8b28e30..4a67b5d05aafef7320ce33e64cb28bc2c855208c 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -68,9 +68,15 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
}
virtual bool RemoveLogin(const PasswordForm& form) OVERRIDE { return false; }
- virtual bool RemoveLoginsCreatedBetween(
- const base::Time& delete_begin,
- const base::Time& delete_end) OVERRIDE {
+ virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
+ base::Time delete_end) OVERRIDE {
+ return false;
+ }
+
+ virtual bool RemoveLoginsSyncedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) OVERRIDE {
return false;
}
@@ -79,8 +85,8 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
return false;
}
- virtual bool GetLoginsCreatedBetween(const base::Time& get_begin,
- const base::Time& get_end,
+ virtual bool GetLoginsCreatedBetween(base::Time get_begin,
+ base::Time get_end,
PasswordFormList* forms) OVERRIDE {
return false;
}
@@ -121,9 +127,8 @@ class MockBackend : public PasswordStoreX::NativeBackend {
return true;
}
- virtual bool RemoveLoginsCreatedBetween(
- const base::Time& delete_begin,
- const base::Time& delete_end) OVERRIDE {
+ virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
+ base::Time delete_end) OVERRIDE {
for (size_t i = 0; i < all_forms_.size(); ++i) {
if (delete_begin <= all_forms_[i].date_created &&
(delete_end.is_null() || all_forms_[i].date_created < delete_end))
@@ -132,6 +137,22 @@ class MockBackend : public PasswordStoreX::NativeBackend {
return true;
}
+ virtual bool RemoveLoginsSyncedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) OVERRIDE {
+ DCHECK(changes);
+ for (size_t i = 0; i < all_forms_.size(); ++i) {
+ if (delete_begin <= all_forms_[i].date_synced &&
+ (delete_end.is_null() || all_forms_[i].date_synced < delete_end)) {
+ changes->push_back(password_manager::PasswordStoreChange(
+ password_manager::PasswordStoreChange::REMOVE, all_forms_[i]));
+ erase(i--);
+ }
+ }
+ return true;
+ }
+
virtual bool GetLogins(const PasswordForm& form,
PasswordFormList* forms) OVERRIDE {
for (size_t i = 0; i < all_forms_.size(); ++i)
@@ -140,8 +161,8 @@ class MockBackend : public PasswordStoreX::NativeBackend {
return true;
}
- virtual bool GetLoginsCreatedBetween(const base::Time& get_begin,
- const base::Time& get_end,
+ virtual bool GetLoginsCreatedBetween(base::Time get_begin,
+ base::Time get_end,
PasswordFormList* forms) OVERRIDE {
for (size_t i = 0; i < all_forms_.size(); ++i)
if (get_begin <= all_forms_[i].date_created &&

Powered by Google App Engine
This is Rietveld 408576698