Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 335893002: Support to remove passwords by date_synced timestamp. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync integration tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index 8fcf8469b17e4bfe64a0db0dcd480a4648fcfc9b..fe5482948d80c7503ad55521c4d2fe6ac386c392 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -54,6 +54,12 @@ class LoginDatabase {
bool RemoveLoginsCreatedBetween(const base::Time delete_begin,
const base::Time delete_end);
+ // Removes all logins synced from |delete_begin| onwards (inclusive) and
+ // before |delete_end|. You may use a null Time value to do an unbounded
+ // delete in either direction.
+ bool RemoveLoginsSyncedBetween(const base::Time delete_begin,
vabr (Chromium) 2014/06/17 16:53:31 nit: remove const (I appreciate the attempt to be
vasilii 2014/06/17 17:24:15 Done.
+ const base::Time delete_end);
+
// Loads a list of matching password forms into the specified vector |forms|.
// The list will contain all possibly relevant entries to the observed |form|,
// including blacklisted matches.
@@ -64,8 +70,16 @@ class LoginDatabase {
// You may use a null Time value to do an unbounded search in either
// direction.
bool GetLoginsCreatedBetween(
- const base::Time begin,
- const base::Time end,
+ base::Time begin,
+ base::Time end,
+ std::vector<autofill::PasswordForm*>* forms) const;
+
+ // Loads all logins synced from |begin| onwards (inclusive) and before |end|.
+ // You may use a null Time value to do an unbounded search in either
+ // direction.
+ bool GetLoginsSyncedBetween(
+ base::Time begin,
+ base::Time end,
std::vector<autofill::PasswordForm*>* forms) const;
// Loads the complete list of autofillable password forms (i.e., not blacklist

Powered by Google App Engine
This is Rietveld 408576698