Support to remove passwords by date_synced timestamp.

chrome/browser/password_manager/password_store_x.cc

Index: chrome/browser/password_manager/password_store_x.cc
diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc
index 8a6fc746d4f276041f6d66dadd272219c1f7412b..bdcc34c1a83b29f26870a6067845c78ca98a961b 100644
--- a/chrome/browser/password_manager/password_store_x.cc
+++ b/chrome/browser/password_manager/password_store_x.cc
@@ -110,6 +110,21 @@ PasswordStoreChangeList PasswordStoreX::RemoveLoginsCreatedBetweenImpl(
   return changes;
 }
 
+PasswordStoreChangeList PasswordStoreX::RemoveLoginsSyncedBetweenImpl(
+    const base::Time& delete_begin,
+    const base::Time& delete_end) {
+  CheckMigration();
+  PasswordStoreChangeList changes;
+  if (use_native_backend() &&
+      backend_->RemoveLoginsSyncedBetween(delete_begin, delete_end, &changes)) {

[Garrett Casto, 2014/06/17 17:57:36]

Seems like we should standardize how we report changes between
RemoveLoginsSyncedBetween() and RemoveLoginsCreatedBetween(). The way we are
doing it here seems reasonable as it removes the GetLoginsCreatedBetween(),
though doing it the other way it closer to how LoginDatabase is structured. I I
think that I prefer this way but it doesn't particular matter which we choose,
it just seems like there is no reason for them to be different.

[vasilii, 2014/06/18 10:00:57]

You are right. The plan is to remove GetLoginsCreatedBetween() in the separate
CL.

+    allow_fallback_ = false;

[Garrett Casto, 2014/06/17 17:57:36]

It also seems like it would be nice if we had UMA stats for this, possibly
update LogStatsForBulkDeletion to handle this? Doesn't need to be in this CL,
but could you file a bug for this so it doesn't get forgotten?

[vasilii, 2014/06/18 10:00:57]

http://crbug.com/386079. The new method will be called when user unsyncs his
profile locally or remotely. I think there will be histograms for that.

+  } else if (allow_default_store()) {
+    changes = PasswordStoreDefault::RemoveLoginsSyncedBetweenImpl(delete_begin,
+                                                                  delete_end);
+  }
+  return changes;
+}
+
 namespace {
 struct LoginLessThan {
   bool operator()(const PasswordForm* a, const PasswordForm* b) {