Support to remove passwords by date_synced timestamp.

chrome/browser/password_manager/password_store_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_x.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
@@ skipping 92 matching lines @@
     LogStatsForBulkDeletion(changes.size());
     allow_fallback_ = false;
   } else if (allow_default_store()) {
     changes = PasswordStoreDefault::RemoveLoginsCreatedBetweenImpl(delete_begin,
                                                                    delete_end);
   }
   STLDeleteElements(&forms);
   return changes;
 }
 
+PasswordStoreChangeList PasswordStoreX::RemoveLoginsSyncedBetweenImpl(
+    const base::Time& delete_begin,
+    const base::Time& delete_end) {
+  CheckMigration();
+  PasswordStoreChangeList changes;
+  if (use_native_backend() &&
+      backend_->RemoveLoginsSyncedBetween(delete_begin, delete_end, &changes)) {

[Garrett Casto, 2014/06/17 17:57:36]

Seems like we should standardize how we report changes between
RemoveLoginsSyncedBetween() and RemoveLoginsCreatedBetween(). The way we are
doing it here seems reasonable as it removes the GetLoginsCreatedBetween(),
though doing it the other way it closer to how LoginDatabase is structured. I I
think that I prefer this way but it doesn't particular matter which we choose,
it just seems like there is no reason for them to be different.

[vasilii, 2014/06/18 10:00:57]

You are right. The plan is to remove GetLoginsCreatedBetween() in the separate
CL.

+    allow_fallback_ = false;

[Garrett Casto, 2014/06/17 17:57:36]

It also seems like it would be nice if we had UMA stats for this, possibly
update LogStatsForBulkDeletion to handle this? Doesn't need to be in this CL,
but could you file a bug for this so it doesn't get forgotten?

[vasilii, 2014/06/18 10:00:57]

http://crbug.com/386079. The new method will be called when user unsyncs his
profile locally or remotely. I think there will be histograms for that.

+  } else if (allow_default_store()) {
+    changes = PasswordStoreDefault::RemoveLoginsSyncedBetweenImpl(delete_begin,
+                                                                  delete_end);
+  }
+  return changes;
+}
+
 namespace {
 struct LoginLessThan {
   bool operator()(const PasswordForm* a, const PasswordForm* b) {
     return a->origin < b->origin;
   }
 };
 }  // anonymous namespace
 
 void PasswordStoreX::SortLoginsByOrigin(NativeBackend::PasswordFormList* list) {
   // In login_database.cc, the query has ORDER BY origin_url. Simulate that.
@@ skipping 144 matching lines @@
       // it before deleting the file just in case there is some problem deleting
       // the file (e.g. directory is not writable, but file is), which would
       // otherwise cause passwords to re-migrate next (or maybe every) time.
       DeleteAndRecreateDatabaseFile();
     }
   }
   ssize_t result = ok ? forms.size() : -1;
   STLDeleteElements(&forms);
   return result;
 }